fix: remove kafka client rename #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgenev
requested review from
elnyry-sam-k,
lewisdaly,
mdebarros,
oderayi and
shashi165
as code owners
mdebarros
reviewed
May 27, 2021
src/models/settlement/facade.js
Outdated
| @@ -1401,8 +1402,14 @@ const Facade = { | |||
| .where('swc.currencyId', knex.raw('COALESCE(?, swc.currencyId)', settlementModel.currencyId)) | |||
| .whereIn('swsc.settlementWindowStateId', [enums.settlementWindowStates.CLOSED, enums.settlementWindowStates.ABORTED, enums.settlementWindowStates.PENDING_SETTLEMENT]) | |||
| .whereIn('swcsc.settlementWindowStateId', [enums.settlementWindowStates.CLOSED, enums.settlementWindowStates.ABORTED]) | |||
| .distinct('swc.settlementWindowContentId') | |||
| const swcIdArray = swcIdList.map(record => record.settlementWindowContentId) | |||
|
|
|||
There was a problem hiding this comment.
Why is this showing as a new addition?
This will ensure that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed kafka client renaming functionality into register handlers - This will ensure that the group.id and client.id set in the config/default.json is correctly used by the Kafka client.
addded
"allow.auto.create.topics": trueinto consumers rdkafka config indefault.jsondue to changes in node-rdkafka version 2.10.0